IDEX l1b Trigger origin, level, and mode fix#2828
Merged
lacoak21 merged 11 commits intoIMAP-Science-Operations-Center:devfrom Mar 10, 2026
Merged
IDEX l1b Trigger origin, level, and mode fix#2828lacoak21 merged 11 commits intoIMAP-Science-Operations-Center:devfrom
lacoak21 merged 11 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes IDEX L1B trigger metadata handling to avoid merge conflicts and to better represent trigger configuration/origin per event, and updates L1A timing calculations to use the trigger-specific sample delay.
Changes:
- Replace merged single
trigger_mode/trigger_leveloutputs with per-gain-channel trigger mode/level variables in L1B and add a newtrigger_originvariable. - Update L1A sample trigger-time calculation to pick the delay based on the trigger ID bits, and fix time-index generation (
linspace→arange). - Update tests and external validation fixtures/mappings to align with new variable names and updated validation-file contents.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| imap_processing/idex/idex_l1b.py | Emits per-channel trigger mode/level variables, adds trigger-origin extraction, and wires these into the L1B dataset. |
| imap_processing/idex/idex_l1a.py | Uses trigger ID to select the appropriate delay field when computing high-sample trigger time; updates time index construction. |
| imap_processing/cdf/config/imap_idex_l1b_variable_attrs.yaml | Replaces single trigger attrs with per-channel attrs and adds attrs for trigger_origin. |
| imap_processing/tests/idex/test_idex_l1b.py | Updates trigger-setting expectations and validation mappings; adjusts validation comparison logic for updated example file. |
| imap_processing/tests/idex/conftest.py | Switches the L1B example validation file name/path used by tests. |
| imap_processing/tests/external_test_data_config.py | Updates external test data download configuration for the renamed IDEX L1B validation file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
tech3371
approved these changes
Mar 10, 2026
Contributor
tech3371
left a comment
tech3371
left a comment
There was a problem hiding this comment.
I looked at the code and code changes makes sense on high level. Thank you for testing though. It helps!
lacoak21
merged commit 3d6feab
into
IMAP-Science-Operations-Center:dev
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
closes #2658
Overview
Fix trigger mode, level, and origin at l1b. Update the rate calculation to use the correct delay.
File changes
Replace merged single trigger_mode/trigger_level outputs with per-gain-channel trigger mode/level variables in L1B and add a new trigger_origin variable.
Update L1A sample trigger-time calculation to pick the delay based on the trigger ID bits, and fix time-index generation (linspace → arange).
Update tests and external validation fixtures/mappings to align with new variable names and updated validation-file contents.
Testing
The validation file from Ethan contains different formatting and variables than we expect. The l1b validation code handles this but we should get a new one eventually.